NonBlocking Sender Scheduling and Bulk Request Buffering #914
+36
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
============================================
- Coverage 74.55% 74.51% -0.04%
+ Complexity 1964 1961 -3
============================================
Files 343 343
Lines 13552 13555 +3
Branches 786 786
============================================
- Hits 10104 10101 -3
- Misses 2960 2964 +4
- Partials 488 490 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
peternied
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the DocumentReindexer logic to use shared threads for subscribing on the bulk request mono (which can be done due to async non-blocking client) as well as updated the unit tests against this behavior.
Updates the DocumentReindexer buffering logic to be 50 bulk requests which can be a more consistent size based on workloads than on a document level.
Issues Resolved
MIGRATIONS-1961
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Tested in AWS against main commit e8e2770 with OR1 and 4vcpu 8gb tasks with
--max-connections 20against 4 node OR1 16xl OS 2.13 cluster with 100 byte docs. Observing lower and more consistent CPU utilization and much lower memory utilization along with ~10% request throughput increaseCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.